Updated nginx runner setup following Exercise requirements #1
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2025 15:22
mauritzs
reviewed
Mar 11, 2025
There was a problem hiding this comment.
I believe these changes are relative to how our server looks? Meaning this might be correct for your case, but I believe it is incorrect for my case, again highlighting the concurrency issues we have here. Maybe we should contact the TA again and ask how we should solve the issue of cooperating in one repo with only limited access for one of the parties...
mauritzs
reviewed
Mar 11, 2025
mauritzs
approved these changes
Mar 13, 2025
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just modified two lines to match what is written on BB. Small PR.